Skip to Main Content

Java EE (Java Enterprise Edition) General Discussion

Announcement

For appeals, questions and feedback about Oracle Forums, please email oracle-forums-moderators_us@oracle.com. Technical questions should be asked in the appropriate category. Thank you!

unclosed string literal error with JSP and SQL query

843836May 22 2005 — edited May 22 2005
I get the follow error when running this script:

An error occurred at line: 24 in the jsp file: /updatePhonebook.jsp
Generated servlet error:
C:\Program Files\Apache Software Foundation\Tomcat 5.0\work\Catalina\localhost\opdracht4\org\apache\jsp\updatePhonebook_jsp.java:84: unclosed string literal
statement.executeUpdate("INSERT INTO Adressenlijst (\"LAST\", \"FIRST\", \"PHONE\") VALUES
^


An error occurred at line: 24 in the jsp file: /updatePhonebook.jsp
Generated servlet error:
C:\Program Files\Apache Software Foundation\Tomcat 5.0\work\Catalina\localhost\opdracht4\org\apache\jsp\updatePhonebook_jsp.java:86: unclosed character literal
(' "+lastValue+" ',' "+firstValue+" ',' "+phoneValue+" ')")";



-->>As far as I know this code is correct. What did I do wrong with the single and double quotes????/





<%@ page contentType="text/html; charset=iso-8859-1" language="java" import="java.sql.*" import="java.util.*" errorPage="" %>


<HTML>
<HEAD><TITLE> Content van database bekijken </TITLE></HEAD>
<BODY>
<P>Database content updaten
<FORM ACTION="updatePhonebook.jsp" METHOD="POST">
   Last name : <INPUT TYPE="TEXT" NAME=lastParam><BR>
   First name : <INPUT TYPE="TEXT" NAME=firstParam><BR>
   Phone numer: <INPUT TYPE="TEXT" NAME=phoneParam><BR>
   
   <INPUT TYPE=Submit VALUE="Add to datababase">
   
</FORM>
<HR>
<P> Content :
<TABLE BORDER=1 CELLPADDING=0 CelLSPACING = 0>
<TD><TD> Last </TD>
<TD><TD> First </TD>
<TD><TD> Phone </TD>
</TR>

<%


Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection connection = DriverManager.getConnection("jdbc:odbc:Henk");


Statement statement  = connection.createStatement();
Enumeration parameters = request.getParameterNames();



if(parameters.hasMoreElements()) {
   String lastValue = request.getParameter("lastParam");
   String firstValue = request.getParameter("firstParam");
   String phoneValue = request.getParameter("phoneParam"); 
   
   statement.executeUpdate("INSERT INTO Adressenlijst (\"LAST\", \"FIRST\", \"PHONE\") VALUES
      
      (' "+lastValue+" ',' "+firstValue+" ',' "+phoneValue+" ')")";
      
}


ResultSet columns = statement.executeQuery (
               "SELECT * FROM Adressenlijst");
               
while(columns.next()) {
   String last = columns.getString("LAST");
   String first = columns.getString("FIRST");
   String phone = columns.getString("PHONE");    %>
     <TR> <TD> <%= last    %> </TD>
     <TR> <TD> <%= first    %> </TD>
     <TR> <TD> <%= phone    %> </TD>
     
    </TR>
    
    
<% }  %>
</TABLE>
</BODY>
</HTML>
 
Comments
Locked Post
New comments cannot be posted to this locked post.
Post Details
Locked on Jun 19 2005
Added on May 22 2005
1 comment
863 views