SQL & PL/SQL

Hi Team,
What is the best way to insert into FACT table using DIM tables.
In my requirement we are inserting in the following way.

For i in (select * from dim1 table) loop
col_val1 = dim2.col1 ;
----
coln_val1 = dimn.coln
insert into fact values (col1..... coln);
end loop;
commit;

Could you please suggest the best way to insert into the fact table

Thanks,