hi all,
i am working on a project in which i do lot of insert and create table queries in one method .
i want that rather then running individual queries i run in batch or transaction but in my code i also check eith table exist or not so they are blend of queries i am pasting my code if some one suggest me some good changes it would be good
insrv="INSERT INTO services(cpid,name,prefix,createdby,serviceformat,createddate,datatransfermode,datareceivingmode)";
insrv+="VALUES("+f.getsrv_cp()+",'"+f.getsrv_name()+"','"+f.getsrv_prefix()+"','imran','"+f.getsrv_format()+"',sysdate,'"+f.getsrv_trf_type()+"','"+f.getsrv_rec_type()+"')";
try
{
rs=connection.executeUpdate(insrv);
if(rs>0)
{
ResultSet rset = connection.executeQuery("SELECT serviceid from services where name='"+f.getsrv_name()+"'");
while( rset.next() )
{
servID=rset.getInt("serviceid");
}
rset.close();
}
}
catch(SQLException e)
{
e.printStackTrace();
e.getMessage();
}//EO TC
//insertion for transfer
if( f.getsrv_trf_type().equals("db") )
{
boolean b=tc.checkTableExist(f.getsrv_trf_dbtype(),f.getsrv_trf_tblname(),f.getsrv_trf_connstr(),f.getsrv_trf_uname(),f.getsrv_trf_password());
if(b!=true)
{
System.out.println("Table is going to be create.");
tc.createTable(f.getsrv_trf_tblname(),f.getsrv_trf_connstr(),f.getsrv_trf_uname(),f.getsrv_trf_password());
}
insrvtrf="INSERT INTO service_db(serviceid,conn_string,username,password,comm_type,tablename,createdby,createddate)"
+ "VALUES("+servID+",'"+f.getsrv_trf_connstr()+"','"+f.getsrv_trf_uname()+"','"+f.getsrv_trf_password()+"','T','"+f.getsrv_trf_tblname()+"','imran',sysdate)";
try
{
log.write(insrvtrf);
rs=connection.executeUpdate(insrvtrf);
}
catch(SQLException e)
{
e.printStackTrace();
}//EO TC
}
else if( f.getsrv_trf_type().equals("url") )
{
insrvtrf="INSERT INTO service_url(serviceid,url,username,password,comm_type,createdby,createddate)"
+ "VALUES("+servID+",'"+f.getsrv_trf_connstr()+"','"+f.getsrv_trf_uname()+"','"+f.getsrv_trf_password()+"','T','imran',sysdate)";
try
{
log.write(insrvtrf);
rs=connection.executeUpdate(insrvtrf);
}
catch(SQLException e)
{
e.printStackTrace();
}//EO TC
}//EO IF-ELSE
//insertion for receiving
if( f.getsrv_rec_type().equals("db") )
{
boolean b=tc.checkTableExist(f.getsrv_rec_dbtype(),f.getsrv_rec_tblname(),f.getsrv_rec_connstr(),f.getsrv_rec_uname(),f.getsrv_rec_password());
if(b!=true)
{
tc.createTable(f.getsrv_rec_tblname(),f.getsrv_rec_connstr(),f.getsrv_rec_uname(),f.getsrv_rec_password());
}
insrvrec="INSERT INTO service_db(serviceid,conn_string,username,password,comm_type,tablename,createdby,createddate)"
+ "VALUES("+servID+",'"+f.getsrv_rec_connstr()+"','"+f.getsrv_rec_uname()+"','"+f.getsrv_rec_password()+"','R','"+f.getsrv_rec_tblname()+"','imran',sysdate)";
try
{
log.write(insrvrec);
rs=connection.executeUpdate(insrvrec);
}
catch(SQLException e)
{
e.printStackTrace();
}//EO TC
}
else if( f.getsrv_rec_type().equals("url") )
{
String crtquery = "Create table url" +servID+ "("
+ " id number, mobilenum varchar2(60),shortcode varchar2(50),message varchar2(254),timein date,"
+ " timeout date,status varchar2(15),type varchar2(15), primary key (id))";
//String drpquery = "drop sequence seq_url" + servID;
String seqquery = "create sequence seq_url" + servID
+ " start with 1"
+ " increment by 1"
+ " maxvalue 9999999"
+ " nocycle";
String trigquery = "create or replace trigger tr_url" + servID
+ " before insert on url" + servID
+ " for each row"
+ " begin"
+ " select seq_url" + servID + ".nextval"
+ " into :new.id"
+ " from dual;"
+ " end;";
/* try
{
debug(drpquery);
rs=connection.executeUpdate(drpquery);
}
catch(SQLException e)
{
log.write( e.getMessage() );
}//EO TC*/
try
{
rs=connection.executeUpdate(crtquery);
rs=connection.executeUpdate(seqquery);
rs=connection.executeUpdate(trigquery);
}
catch(SQLException e)
{
e.printStackTrace();
}//EO TC
insrvrec="INSERT INTO service_url(serviceid,url,username,password,comm_type,createdby,createddate)"
+ "VALUES("+servID+",'"+f.getsrv_rec_connstr()+"','"+f.getsrv_rec_uname()+"','"+f.getsrv_rec_password()+"','R','imran',sysdate)";
try
{
log.write(insrvrec);
rs=connection.executeUpdate(insrvrec);
}
catch(SQLException e)
{
e.printStackTrace();
}//EO TC
}//EO IF-ELSE
inshortcode="INSERT INTO service_shortcode(serviceid,shortcode) VALUES("+servID+",'"+f.getsrv_shortcode()+"')";
try
{
log.write(inshortcode);
rs=connection.executeUpdate(inshortcode);
}
catch(SQLException e)
{
//e.printStackTrace();
log.write("in srv insert exception"+e.getMessage());
}//EO TC